Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-04-02 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123095/ --- (Updated April 2, 2015, 12:41 p.m.) Status -- This change has been

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-04-02 Thread Gregor Mi
On March 30, 2015, 9:33 p.m., Gilles Caulier wrote: yes. libkipi is fully ported to KF5. Kipi-plugins is partially ported (only 6 tools). It's enough to test. https://techbase.kde.org/Projects/Digikam/CodingSprint2014 I explicitly did `./kdesrc-build libkipi libkexiv2 libkdcraw

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-31 Thread Laurent Montel
On mars 31, 2015, 5:07 matin, Laurent Montel wrote: Yes but your review doesn't fix bug no ? You add more debug but it doesn't fix bug no ? For me it's better that you create a review about a fix not just add debug and wait that it will fix no ? Gregor Mi wrote: Hi Laurent,

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-31 Thread Gregor Mi
On March 31, 2015, 5:07 a.m., Laurent Montel wrote: Yes but your review doesn't fix bug no ? You add more debug but it doesn't fix bug no ? For me it's better that you create a review about a fix not just add debug and wait that it will fix no ? Hi Laurent, sorry for the confusion. I

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-30 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123095/#review78259 --- yes. libkipi is fully ported to KF5. Kipi-plugins is

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-30 Thread Albert Astals Cid
On mar. 30, 2015, 9:22 p.m., Gregor Mi wrote: Hi, who could confirm that the kipi plugins are currently supposed to work with ksnapshot or not? is there a KF5-version of libkipi and of the kipi plugins? - Albert --- This is an

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-30 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123095/ --- (Updated March 30, 2015, 9:22 p.m.) Review request for KDE Frameworks,

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-30 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123095/#review78263 --- Yes but your review doesn't fix bug no ? You add more debug