Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2017-03-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/ --- (Updated mar. 3, 2017, 5:02 p.m.) Status -- This change has been

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review102609 --- Patch doesn't apply anymore. - Albert Astals Cid On Dec.

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-12-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review89297 --- OK, at least it makes more sense to me now. We register at

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-12-09 Thread Aleix Pol Gonzalez
> On April 7, 2015, 5:38 p.m., Aleix Pol Gonzalez wrote: > > src/widgets/jobuidelegate.cpp, line 391 > > > > > > This is not correct, it's too early to figure out if it's going to have > > a QApplication or

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-12-09 Thread Aleix Pol Gonzalez
> On Dec. 8, 2015, 9 a.m., David Faure wrote: > > I don't understand why the move to Q_COREAPP_STARTUP_FUNCTION. That startup > > function is only about creating some singleton, not about registering a > > KJob (which is where the qApp type check happens). > > > > If the startup function

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-12-08 Thread David Faure
> On April 7, 2015, 3:38 p.m., Aleix Pol Gonzalez wrote: > > src/widgets/jobuidelegate.cpp, line 391 > > > > > > This is not correct, it's too early to figure out if it's going to have > > a QApplication or

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-12-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review89239 --- I don't understand why the move to

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-12-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/ --- (Updated Dec. 7, 2015, 2:29 p.m.) Review request for KDE Frameworks.

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-04-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review78665 --- src/widgets/jobuidelegate.cpp (line 391)

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-04-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/ --- (Updated April 7, 2015, 2:41 p.m.) Review request for KDE Frameworks.

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-04-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review78619 --- Ship it! Ship It! - David Faure On April 7, 2015, 12:41

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-04-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/ --- (Updated April 7, 2015, 1:46 p.m.) Status -- This change has been

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-04-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review78633 --- src/widgets/jobuidelegate.cpp (line 391)

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-04-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review78476 --- src/widgets/kdynamicjobtracker.cpp (line 84)

Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-04-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/ --- Review request for KDE Frameworks. Repository: kio Description ---