---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123397/#review79260
---
Ship it!
Ship It!
- Alex Richardson
On April 17, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123397/#review79123
---
does this error out properly when the install namespace is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123397/
---
Review request for KDE Frameworks and Alex Richardson.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123397/
---
(Updated April 17, 2015, 4:53 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123397/#review79131
---
KF5CoreAddonsMacros.cmake (line 108)
On April 17, 2015, 5:06 p.m., Alex Richardson wrote:
KF5CoreAddonsMacros.cmake, line 108
https://git.reviewboard.kde.org/r/123397/diff/2/?file=361637#file361637line108
I would also grep for Q_PLUGIN_METADATA(IID ... FILE foo.json).
Also maybe make the macro name customizable.