Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

2015-05-09 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123532/#review80119 --- So the usual pattern for CMake find modules is to use pkgconfi

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

2015-04-30 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123532/ --- (Updated Dub. 30, 2015, 8:33 dop.) Review request for KDE Frameworks and

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

2015-04-29 Thread Jan Grulich
> On Dub. 28, 2015, 4:09 odp., Lamarque Souza wrote: > > It worked here, so it's a +1 from me. I just would like the > > extra-cmake-module maintainer to give the final "ship it". > > Jan Grulich wrote: > Hmm, I realized that this would break backward compatibility with > plasma-nm, becaus

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

2015-04-29 Thread Jan Grulich
> On Dub. 28, 2015, 4:09 odp., Lamarque Souza wrote: > > It worked here, so it's a +1 from me. I just would like the > > extra-cmake-module maintainer to give the final "ship it". Hmm, I realized that this would break backward compatibility with plasma-nm, because in plasma-nm we use NETWORKMA

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

2015-04-28 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123532/#review79633 --- It worked here, so it's a +1 from me. I just would like the ex

Review Request 123532: Add find modules for ModemManager and NetworkManager

2015-04-27 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123532/ --- Review request for KDE Frameworks and Lamarque Souza. Repository: extra-c