Re: Review Request 123542: [runtime] Move platform specific code into plugins

2015-05-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123542/ --- (Updated May 12, 2015, 10:50 a.m.) Status -- This change has been ma

Re: Review Request 123542: [runtime] Move platform specific code into plugins

2015-05-05 Thread Martin Gräßlin
> On May 5, 2015, 11:05 a.m., Martin Klapetek wrote: > > Looks good; though let's first ship > > https://git.reviewboard.kde.org/r/122680/ - I think it will be easier to > > rebase your changes on top of this rather than the other way around. I'll > > fix the https://git.reviewboard.kde.org/r/

Re: Review Request 123542: [runtime] Move platform specific code into plugins

2015-05-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123542/#review79889 --- Ship it! Looks good; though let's first ship https://git.revi

Re: Review Request 123542: [runtime] Move platform specific code into plugins

2015-04-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123542/ --- (Updated April 29, 2015, 8:23 a.m.) Review request for KDE Frameworks and

Re: Review Request 123542: [runtime] Move platform specific code into plugins

2015-04-28 Thread Martin Gräßlin
> On April 28, 2015, 7:31 p.m., Alex Richardson wrote: > > src/runtime/globalshortcutsregistry.cpp, line 40 > > > > > > You could use > > `KPluginLoader::forEachPlugin("org.kde.kglobalaccel5.platforms", [&](const

Re: Review Request 123542: [runtime] Move platform specific code into plugins

2015-04-28 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123542/#review79637 --- src/runtime/globalshortcutsregistry.cpp (line 40)

Review Request 123542: [runtime] Move platform specific code into plugins

2015-04-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123542/ --- Review request for KDE Frameworks, kdewin and Martin Klapetek. Repository