Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/ --- (Updated July 7, 2015, 11:26 a.m.) Status -- This change has been ma

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/ --- (Updated Juni 30, 2015, 4:11 nachm.) Review request for KDE Frameworks.

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81893 --- src/kaboutapplicationdialog.cpp (line 155)

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On June 20, 2015, 7:10 p.m., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81891 --- +1 to move the version into a separate tab. +1 to keeping Abou

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On June 30, 2015, 10:41 a.m., Martin Gräßlin wrote: > > ping applications maintainers: please also consider whether version should > > be first tab or whether about should stay first tab. > > Albert Astals Cid wrote: > If we are going to do this, "About" should be the first tab, after all

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On jun. 30, 2015, 8:41 a.m., Martin Gräßlin wrote: > > ping applications maintainers: please also consider whether version should > > be first tab or whether about should stay first tab. If we are going to do this, "About" should be the first tab, after all i'm getting to that dialog by doin

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On June 20, 2015, 9:10 p.m., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81885 --- ping applications maintainers: please also consider whether ve

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On June 20, 2015, 9:10 p.m., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On Июнь 20, 2015, 7:10 п.п., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On June 20, 2015, 9:10 p.m., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On June 20, 2015, 9:10 p.m., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On June 20, 2015, 7:10 p.m., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81603 --- +1 for adding all that info -1 for putting it into its own tab

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On June 20, 2015, 8:02 p.m., Alexander Potashev wrote: > > typo: "build against [...]" -> "built against [...]" thanks, fixed locally. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kd

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On June 20, 2015, 7:20 p.m., Christoph Cullmann wrote: > > +1 for the additional information. > > Btw., is there any way we would get that info submitted for bugs, too? > > (which is a different thingy, I know, just came to mind) probably needs to be added to KCrash for that. And yes that sou

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81599 --- typo: "build against [...]" -> "built against [...]" - Alexan

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81596 --- +1 for the additional information. Btw., is there any way we w

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81586 --- +1, this is useful and a clean implementation IMO. - Sebastia

Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/ --- Review request for KDE Frameworks. Repository: kxmlgui Description