---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/
---
(Updated June 29, 2015, 9:39 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/
---
(Updated June 29, 2015, 9:54 a.m.)
Status
--
This change has been
On June 29, 2015, 8:40 a.m., David Faure wrote:
src/karchive.cpp, line 684
https://git.reviewboard.kde.org/r/124165/diff/3/?file=381630#file381630line684
The /8 /8 %2 bit looks too arithmetic to me, this should be 'bitwise
and' instead (faster, more approriate here, and IMHO more
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/#review81852
---
Ship it!
Ship It!
- David Faure
On June 29, 2015, 9:39
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/#review81846
---
(Hehe, that unittest should clearly use some ++int rather
On June 29, 2015, 8:40 a.m., David Faure wrote:
src/karchive.cpp, line 684
https://git.reviewboard.kde.org/r/124165/diff/3/?file=381630#file381630line684
The /8 /8 %2 bit looks too arithmetic to me, this should be 'bitwise
and' instead (faster, more approriate here, and IMHO more
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/
---
(Updated June 28, 2015, 10:31 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/
---
(Updated June 25, 2015, 12:44 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/#review81749
---
At this point I wonder if three if()s wouldn't be a lot less
