Re: Review Request 124413: Enable PAM opening KWallet again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 27, 2015, 11:06 a.m.) Status -- This change has been m

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 27, 2015, 8:02 a.m., Valentin Rusu wrote: > > Ship It! and thanks for this. - Valentin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review83014 -

Re: Review Request 124413: Enable PAM opening KWallet again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review83014 --- Ship it! Ship It! - Valentin Rusu On July 21, 2015, 5:27 p

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: > > src/runtime/kwalletd/main.cpp, line 113 > > > > > > You should use strncmp instead of strcmp. > > Martin Klapetek wrote: > Why would you think? The wh

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: > > src/runtime/kwalletd/main.cpp, line 113 > > > > > > You should use strncmp instead of strcmp. > > Martin Klapetek wrote: > Why would you think? The wh

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: > > src/runtime/kwalletd/main.cpp, line 113 > > > > > > You should use strncmp instead of strcmp. > > Martin Klapetek wrote: > Why would you think? The wh

Re: Review Request 124413: Enable PAM opening KWallet again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 21, 2015, 7:27 p.m.) Review request for KDE Frameworks, Àle

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 21, 2015, 5:57 p.m., Lamarque Souza wrote: > > src/runtime/kwalletd/main.cpp, line 144 > > > > > > You should deallocate hash here if it is not null, otherwise you have a > > memory leak. > > Martin K

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 21, 2015, 5:57 p.m., Lamarque Souza wrote: > > src/runtime/kwalletd/main.cpp, line 113 > > > > > > You should use strncmp instead of strcmp. Why would you think? The whole string is being compared, wha

Re: Review Request 124413: Enable PAM opening KWallet again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review82770 --- src/runtime/kwalletd/main.cpp (line 113)

Review Request 124413: Enable PAM opening KWallet again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet