Re: Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124607/ --- (Updated Aug. 5, 2015, 9:38 p.m.) Status -- This change has been mar

Re: Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

> On Aug. 5, 2015, 9:08 a.m., Milian Wolff wrote: > > src/services/kservicegroup.cpp, line 680 > > > > > > what about putting these calls into `KServiceGroupFactory::self()`? It > > seems to me that this would r

Re: Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124607/#review83448 --- Ship it! src/services/kservicegroup.cpp (line 680)

Re: Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124607/ --- (Updated Aug. 5, 2015, 8:09 a.m.) Review request for KDE Frameworks and V

Re: Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

> On Aug. 4, 2015, 9:43 a.m., Alex Merry wrote: > > src/sycoca/ksycoca.h, line 177 > > > > > > Why have a bool return type on an internal method, when no call > > actually uses that value? Excellent question :-

Re: Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124607/#review83416 --- src/sycoca/ksycoca.h (line 177)

Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124607/ --- Review request for KDE Frameworks and Vishesh Handa. Repository: kservice