Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-10-21 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/#review87214 --- Update: the fix for QTBUG 39660, which landed in Qt 5.5.1,

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Aug. 28, 2015, 7:54 a.m.) Status -- This change has been

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/#review84491 --- Ship it! Ship It! - David Faure On Aug. 26, 2015, 10:36

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-27 Thread Christoph Feck
On Aug. 27, 2015, 9:35 p.m., David Faure wrote: Ship It! Does it make sense to also have this feature in KNewPasswordDialog? - Christoph --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-27 Thread Elvis Angelaccio
On Ago. 27, 2015, 9:35 p.m., David Faure wrote: Ship It! Christoph Feck wrote: Does it make sense to also have this feature in KNewPasswordDialog? I have another RR ready to submit after this one. I'd like to add a new widget called `KNewPasswordWidget`, meant to be used in custom

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/#review84390 --- Very cool. But let's wait for Plasma 5.5 to be released then?

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-26 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Ago. 26, 2015, 10:36 a.m.) Review request for KDE Frameworks

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-25 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Ago. 25, 2015, 7:15 p.m.) Review request for KDE Frameworks and

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/#review83822 --- Cool feature. I think the icon for this more usually looks

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-15 Thread Elvis Angelaccio
On Ago. 15, 2015, 10:36 a.m., David Faure wrote: Cool feature. I think the icon for this more usually looks like an eye, no? (so indeed I would encourage you to request a better icon from the artists / VDG / whoever makes icons these days) ;) Code looks good to me (and I just

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Ago. 15, 2015, 1:31 p.m.) Review request for KDE Frameworks and

Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-11 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- Review request for KDE Frameworks, KDE Usability and Christoph Feck.

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-11 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/#review83709 --- src/kpassworddialog.cpp (line 128)

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-11 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Ago. 11, 2015, 3:46 p.m.) Review request for KDE Frameworks and