---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/
---
(Updated July 13, 2016, 10:31 p.m.)
Status
--
This change has been d
> On Aug. 20, 2015, 4:54 p.m., Volker Krause wrote:
> > Sorry, still doesn't seem to fix KMail's QIcon::fromTheme() usage here,
> > hits the disk as before.
IIUC insertion into the persistent cache only happens when actually rendering
the icon, right? I am trying to debug this with KMail, my c
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/#review84095
---
Sorry, still doesn't seem to fix KMail's QIcon::fromTheme() us
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/#review84094
---
Ship it!
lgtm, but I don't like that kiconthemes_unittests_se
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/
---
(Updated Aug. 20, 2015, 8:07 a.m.)
Review request for KDE Frameworks and
> On Aug. 19, 2015, 5:52 p.m., Volker Krause wrote:
> > Sorry, this does not change the KMail case, it's still hitting the disk for
> > the first icon of each type requested via QIcon::fromTheme, after that the
> > in-memory cache kicks in.
> >
> > IIUC the problem is that on the pure QIcon::f
> On Aug. 19, 2015, 5:52 p.m., Volker Krause wrote:
> > Sorry, this does not change the KMail case, it's still hitting the disk for
> > the first icon of each type requested via QIcon::fromTheme, after that the
> > in-memory cache kicks in.
> >
> > IIUC the problem is that on the pure QIcon::f
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/#review84060
---
Sorry, this does not change the KMail case, it's still hitting
> On Aug. 19, 2015, 8:02 a.m., Mark Gaiser wrote:
> > Hi David,
> >
> > This probably makes it faster (i have no doubt there), but i don't really
> > follow how this works.
> > Could you perhaps explain what you're doing exactly here?
> >
> > For instance, how can you determine if something is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/#review84027
---
Hi David,
This probably makes it faster (i have no doubt ther
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/#review84026
---
Awesome, thanks! I'll test it on KMail tonight.
- Volker Krau
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/
---
Review request for KDE Frameworks, Christoph Feck and Volker Krause.
Repo
12 matches
Mail list logo
