Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Kevin Funk
On Aug. 24, 2015, 11:52 a.m., Kevin Funk wrote: src/kglobalaccel.cpp, line 97 https://git.reviewboard.kde.org/r/124902/diff/1/?file=397839#file397839line97 Indeed. Just move into iface()? Martin Gräßlin wrote: it's also used for setting up the QDBusServiceWatcher in the

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Martin Gräßlin
On Aug. 24, 2015, 1:52 p.m., Kevin Funk wrote: src/kglobalaccel.cpp, line 97 https://git.reviewboard.kde.org/r/124902/diff/1/?file=397839#file397839line97 Indeed. Just move into iface()? it's also used for setting up the QDBusServiceWatcher in the KGlobalAccelPrivate ctor. So not

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/ --- (Updated Aug. 24, 2015, 2:13 p.m.) Review request for KDE Frameworks and

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/ --- (Updated Aug. 24, 2015, 2:59 p.m.) Review request for KDE Frameworks and

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/#review84290 --- Ship it! Ship It! - Milian Wolff On Aug. 24, 2015, 12:59

Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/ --- Review request for KDE Frameworks and Kevin Funk. Repository:

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/#review84264 --- src/kglobalaccel.cpp (line 97)

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/#review84266 --- Can confirm. With that patch kglobalaccel5 is no longer

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/ --- (Updated Aug. 25, 2015, 5:58 a.m.) Status -- This change has been