On Aug. 24, 2015, 11:18 p.m., Alex Richardson wrote:
src/core/slave.cpp, line 89
https://git.reviewboard.kde.org/r/124904/diff/2/?file=397847#file397847line89
Unrelated but while you're touching this code maybe change this to
qEnvironmentVariableIsSet(). More efficient and easier
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124904/
---
(Updated Aug. 25, 2015, 7:10 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124904/#review84318
---
Ship it!
Ship It!
- David Faure
On Aug. 24, 2015, 1:11
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124904/
---
Review request for KDE Frameworks, David Faure and Boudewijn Rempt.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124904/
---
(Updated Aug. 24, 2015, 1:11 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124904/#review84309
---
Looks good to me
src/core/slave.cpp (line 88)
