Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/#review87241 --- Ship it! Ship It! - David Faure On Oct. 20, 2015, 9:20

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/#review87117 --- Almost there ;) src/kcollapsiblegroupbox.h (line 47)

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Oct. 20, 2015, 9:20 p.m.) Review request for KDE Frameworks and

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Oct. 19, 2015, 10:27 p.m.) Review request for KDE Frameworks

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Oct. 19, 2015, 10:32 p.m.) Review request for KDE Frameworks

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/#review86639 --- src/CMakeLists.txt (line 12)

Re: Review Request 125325: New widget KCollapsibleGroupBox

> On Oct. 3, 2015, 9:54 p.m., David Faure wrote: > > Thanks > On Oct. 3, 2015, 9:54 p.m., David Faure wrote: > > tests/kcollapsiblegroupboxtest.cpp, line 35 > > > > > > just curious: why? We don't know which

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Oct. 4, 2015, 8:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/#review86315 --- src/kcollapsiblegroupbox.h (line 21)

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/#review85862 --- +1 on the idea. Note that gtk has such a widget (which looks

Re: Review Request 125325: New widget KCollapsibleGroupBox

> On Sept. 24, 2015, 8:04 a.m., Hugo Pereira Da Costa wrote: > > +1 on the idea. > > Note that gtk has such a widget (which looks exactly like yours) since > > quite some time already Testing, there are some issues though. The fact for instance that mouse-over and focus are deliberatly

Re: Review Request 125325: New widget KCollapsibleGroupBox

> On Sept. 24, 2015, 8:04 a.m., Hugo Pereira Da Costa wrote: > > +1 on the idea. > > Note that gtk has such a widget (which looks exactly like yours) since > > quite some time already > > Hugo Pereira Da Costa wrote: > Testing, there are some issues though. The fact for instance that >

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Sept. 24, 2015, 7:34 p.m.) Review request for KDE Frameworks

Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Sept. 20, 2015, 3:55 p.m.) Review request for KDE Frameworks

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/#review85688 --- I like the concept. src/kcollapsiblegroupbox.h (line 4)

Re: Review Request 125325: New widget KCollapsibleGroupBox

> On Sept. 20, 2015, 2:08 p.m., Sune Vuorela wrote: > > src/kcollapsiblegroupbox.h, line 34 > > > > > > Does it handle 1000 items, or is it up to the user to ensure to limit > > it or add it in a scrollarea? > >