Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-24 Thread Marco Martin
> On Sept. 23, 2015, 4:46 p.m., David Edmundson wrote: > > src/plasma/private/applet_p.cpp, line 171 > > > > > > +1 to the idea, > > > > I'm not sure this is the right place though. > > We have an

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-24 Thread Marco Martin
> On Sept. 23, 2015, 4:46 p.m., David Edmundson wrote: > > src/plasma/private/applet_p.cpp, line 171 > > > > > > +1 to the idea, > > > > I'm not sure this is the right place though. > > We have an

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125336/ --- (Updated Sept. 24, 2015, 10:12 a.m.) Review request for KDE Frameworks

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125336/#review85868 --- Ship it! Ship It! - David Edmundson On Sept. 24, 2015,

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125336/ --- (Updated Sept. 24, 2015, 7:03 p.m.) Status -- This change has been

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-23 Thread Marco Martin
> On Sept. 23, 2015, 4:46 p.m., David Edmundson wrote: > > src/plasma/private/packages.cpp, line 107 > > > > > > this is unrelated? ah, yeah, should have got in separately > On Sept. 23, 2015, 4:46 p.m.,

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125336/ --- (Updated Sept. 21, 2015, 6:11 p.m.) Review request for KDE Frameworks

Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125336/ --- Review request for KDE Frameworks and Plasma. Repository: