Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-10-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review87248 --- src/widgets/koverlayiconplugin.h (line 44)

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review87045 --- Ship it! src/widgets/koverlayiconplugin.h (line 37)

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-10-19 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/ --- (Updated Oct. 19, 2015, 9:08 a.m.) Status -- This change has been

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-10-17 Thread Olivier Goffart
> On Sept. 28, 2015, 6:25 nachm., Sune Vuorela wrote: > > src/widgets/koverlayiconplugin.h, line 55 > > > > > > Is a plugin expected to return multiple overlays, and if so are > > consumers of this interface

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-10-17 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/ --- (Updated Okt. 17, 2015, 3:06 nachm.) Review request for Dolphin and KDE

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-10-17 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86979 --- Used in dolphin: https://git.reviewboard.kde.org/r/125675/ -

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-10-03 Thread David Faure
> On Sept. 28, 2015, 8:34 p.m., Olivier Goffart wrote: > > src/widgets/koverlayiconplugin.desktop, line 3 > > > > > > Do you have any example of plugins using this new way so that i can get > > inspiration from

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86070 --- src/widgets/koverlayiconplugin.desktop (line 3)

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86063 --- src/widgets/koverlayiconplugin.h (line 55)

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86074 --- src/widgets/koverlayiconplugin.desktop (line 3)

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/ --- (Updated Sept. 28, 2015, 9:14 vorm.) Review request for Dolphin and KDE

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86034 --- Maybe i should return a QList instead of a QStringList? -

Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/ --- Review request for Dolphin and KDE Frameworks. Repository: kio