---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125681/
---
(Updated Oct. 20, 2015, 11:08 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125681/#review87107
---
Ship it!
Looks reasonable to me, so I'd implement as long as
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125681/
---
(Updated Oct. 18, 2015, 8:58 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125681/
---
Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125681/#review86991
---
Ship it!
I agree that the current code is broken, and that
> On Oct. 18, 2015, 1:52 a.m., Michael Pyne wrote:
> > I agree that the current code is broken, and that your fix makes sense
> > given the surrounding comments clarifying ownership. But why not simply
> > construct the print settings object with the dialog as a parent? I see no
> > reason
> On Oct. 18, 2015, 1:52 a.m., Michael Pyne wrote:
> > I agree that the current code is broken, and that your fix makes sense
> > given the surrounding comments clarifying ownership. But why not simply
> > construct the print settings object with the dialog as a parent? I see no
> > reason
