Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125691/ --- (Updated Oct. 29, 2015, 6:35 p.m.) Status -- This change has been

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

> On Oct. 27, 2015, 8 a.m., David Faure wrote: > > src/widgets/kopenwithdialog.cpp, line 970 > > > > > > This else should be removed, then. > > > > There's no reason to only set m_pService when mimetype

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

> On Oct. 27, 2015, 8 a.m., David Faure wrote: > > src/widgets/kopenwithdialog.cpp, line 970 > > > > > > This else should be removed, then. > > > > There's no reason to only set m_pService when mimetype

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125691/#review87487 --- Ah OK. When creating a KOpenWithDialog without a mimetype

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125691/#review87244 --- src/widgets/kopenwithdialog.cpp (line 911)

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

> On Oct. 22, 2015, 7:30 a.m., David Faure wrote: > > src/widgets/kopenwithdialog.cpp, line 911 > > > > > > How about changing this condition to > >(...) && !qMimeType.isEmpty() ? > > > > If

Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125691/ --- Review request for KDE Frameworks. Repository: kio Description ---