Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126002/ --- (Updated Nov. 9, 2015, 12:46 p.m.) Status -- This change has been ma

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126002/#review88182 --- Ship it! ouch, I was bitten by that in KDevelop as well...

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread Nick Shaforostoff
> On Nov. 9, 2015, 10:42 a.m., Nick Shaforostoff wrote: > > src/ktar.cpp, line 293 > > > > > > why can't we just use QFile::decodeName(const char * localFileName) > > overload? ok, there is a limit of 100. then

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126002/#review88178 --- src/ktar.cpp (line 292)

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126002/ --- (Updated Nov. 9, 2015, 7:54 a.m.) Review request for KDE Frameworks. Ch