Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-28 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/ --- (Updated Dec. 28, 2015, 4:08 p.m.) Status -- This change has been

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-21 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/ --- (Updated Dec. 21, 2015, 9:45 a.m.) Review request for KDE Frameworks.

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-21 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/#review89815 --- Ship it! My nitpicks have been resolved, a weak +1 from my

Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-14 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/#review89472 --- Looks good to me, though I wouldn't mind another reviewer.

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-14 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/#review89480 --- Just a few nitpicks. Rest looks good to me.