Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/ --- (Updated Jan. 4, 2016, 8:04 p.m.) Status -- This change has been mar

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review90303 --- Ship it! Ship It! - Marco Martin On Dec. 15, 2015, 3:24 p.

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review90302 --- Ship it! Ship It! - Sebastian Kügler On Dec. 15, 2015, 3:2

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89823 --- bump? - Aleix Pol Gonzalez On Dec. 15, 2015, 4:24 p.m., Ale

Re: Review Request 126348: Make it possible to provide the metadata in json

> On Dec. 14, 2015, 9:50 p.m., Sebastian Kügler wrote: > > src/kpackage/private/packagejobthread.cpp, line 189 > > > > > > Why this change? > > Aleix Pol Gonzalez wrote: > because currently it's not a text f

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89556 --- src/kpackage/package.cpp (line 24)

Re: Review Request 126348: Make it possible to provide the metadata in json

> On Dec. 14, 2015, 10:50 p.m., Sebastian Kügler wrote: > > src/kpackage/private/packagejobthread.cpp, line 189 > > > > > > Why this change? because currently it's not a text file. I can commit separately if you

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/ --- (Updated Dec. 15, 2015, 4:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89504 --- src/kpackage/private/packages.cpp (line 57)

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89499 --- src/kpackage/package.cpp (line 447)

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89482 --- Can't really comment on KPackage internals, but looks good to

Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc