Re: Review Request 126505: Do not show a warning color before the user even started typing

2016-01-04 Thread Elvis Angelaccio
> On Jan. 2, 2016, 11:33 a.m., David Faure wrote: > > Ship It! Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's because I have kwidgetsaddons 5.17 globally installed from archlinux repos (indeed, the warning color in my local tests is set as soon as something is

Re: Review Request 126505: Do not show a warning color before the user even started typing

2016-01-04 Thread David Faure
> On Jan. 2, 2016, 11:33 a.m., David Faure wrote: > > Ship It! > > Elvis Angelaccio wrote: > Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's > because I have kwidgetsaddons 5.17 globally installed from archlinux repos > (indeed, the warning color in my local

Re: Review Request 126505: Do not show a warning color before the user even started typing

2016-01-04 Thread Elvis Angelaccio
> On Jan. 2, 2016, 11:33 a.m., David Faure wrote: > > Ship It! > > Elvis Angelaccio wrote: > Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's > because I have kwidgetsaddons 5.17 globally installed from archlinux repos > (indeed, the warning color in my local

Re: Review Request 126505: Do not show a warning color before the user even started typing

2016-01-04 Thread David Faure
> On Jan. 2, 2016, 11:33 a.m., David Faure wrote: > > Ship It! > > Elvis Angelaccio wrote: > Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's > because I have kwidgetsaddons 5.17 globally installed from archlinux repos > (indeed, the warning color in my local

Re: Review Request 126505: Do not show a warning color before the user even started typing

2016-01-04 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/ --- (Updated Jan. 4, 2016, 2:46 p.m.) Status -- This change has been

Re: Review Request 126505: Do not show a warning color before the user even started typing

2016-01-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/#review90441 --- Ship it! Ship It! - David Faure On Dec. 27, 2015, 2:40

Re: Review Request 126505: Do not show a warning color before the user even started typing

2015-12-27 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/ --- (Updated Dec. 27, 2015, 2:36 p.m.) Review request for KDE Frameworks and

Re: Review Request 126505: Do not show a warning color before the user even started typing

2015-12-27 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/ --- (Updated Dec. 27, 2015, 2:40 p.m.) Review request for KDE Frameworks,

Re: Review Request 126505: Do not show a warning color before the user even started typing

2015-12-26 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/#review90126 --- Just one question: Why should a mismatch only be considered

Re: Review Request 126505: Do not show a warning color before the user even started typing

2015-12-26 Thread Elvis Angelaccio
> On Dec. 26, 2015, 10:17 p.m., Thomas Pfeiffer wrote: > > Just one question: Why should a mismatch only be considered when the two > > have the same length? > > Couldn't you show the warning as soon as an actual mismatch is detected, > > even if that happens before the confirmation password

Review Request 126505: Do not show a warning color before the user even started typing

2015-12-24 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/ --- Review request for KDE Frameworks, KDE Usability, Christoph Feck, David