Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-29 Thread Martin Klapetek
> On Feb. 29, 2016, 11:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-29 Thread Martin Klapetek
> On Feb. 29, 2016, 11:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-29 Thread Andreas Kainz
> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-29 Thread Heiko Tietze
> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-29 Thread Elvis Angelaccio
> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-29 Thread Andreas Kainz
> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-29 Thread Elvis Angelaccio
> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-29 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/#review92946 --- hi, heiko fill a bug report cause you cant see the x icon

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-01 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/ --- (Updated Feb. 1, 2016, 6:47 p.m.) Status -- This change has been

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-01 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/#review91864 --- Ping? - Elvis Angelaccio On Jan. 23, 2016, 11:29 a.m.,

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/#review91869 --- Ship it! Ship It! - David Edmundson On Jan. 23, 2016,

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-01-11 Thread Elvis Angelaccio
> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. > > Kai Uwe Broulik wrote: > Do we even need the close button to begin with? It's not like it > appearing is really under

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-30 Thread Elvis Angelaccio
> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. > > Kai Uwe Broulik wrote: > Do we even need the close button to begin with? It's not like it > appearing is really under

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-30 Thread Elvis Angelaccio
> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. > > Kai Uwe Broulik wrote: > Do we even need the close button to begin with? It's not like it > appearing is really under

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-30 Thread Thomas Pfeiffer
> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. > > Kai Uwe Broulik wrote: > Do we even need the close button to begin with? It's not like it > appearing is really under

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-27 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/#review90137 --- Ship it! Perfect use of the message panel. However, the red

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-27 Thread Heiko Tietze
> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. > > Kai Uwe Broulik wrote: > Do we even need the close button to begin with? It's not like it > appearing is really under

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-27 Thread Kai Uwe Broulik
> On Dez. 27, 2015, 9:21 vorm., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. Do we even need the close button to begin with? It's not like it appearing is really under your direct control anyway. -

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-27 Thread Thomas Pfeiffer
> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. > > Kai Uwe Broulik wrote: > Do we even need the close button to begin with? It's not like it > appearing is really under

Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-26 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/ --- Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, and