Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-06-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/#review96491 --- The patch makes sense to me. It's watching for items being d

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-06-14 Thread Sune Vuorela
> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote: > > Do you still have the sample application you made to test/verify this? I'd > > like to try it and it should probably be committed too. > > Pino Toscano wrote: > No I don't :-/ I remember it was just removing indexes with associated >

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-06-14 Thread David Edmundson
> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote: > > Do you still have the sample application you made to test/verify this? I'd > > like to try it and it should probably be committed too. > > Pino Toscano wrote: > No I don't :-/ I remember it was just removing indexes with associated >

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-05-23 Thread Stephen Kelly
> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote: > > Do you still have the sample application you made to test/verify this? I'd > > like to try it and it should probably be committed too. > > Pino Toscano wrote: > No I don't :-/ I remember it was just removing indexes with associated >

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-05-20 Thread Pino Toscano
> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote: > > Do you still have the sample application you made to test/verify this? I'd > > like to try it and it should probably be committed too. No I don't :-/ I remember it was just removing indexes with associated widgets. - Pino

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-03-28 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/#review94076 --- Do you still have the sample application you made to test/ver

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-03-28 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/#review94071 --- ping - Pino Toscano On Mar. 28, 2016, 1:39 p.m., Pino Tosc

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-01-02 Thread Pino Toscano
> On Gen. 2, 2016, 7:31 p.m., Sune Vuorela wrote: > > Looks much better than my attempt over in > > https://git.reviewboard.kde.org/r/120139 Note my patch does not remove the warnings on close, although I found out how to avoid them: to the KWidgetItemDelegate construr, either pass a null pare

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-01-02 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/#review90477 --- Looks much better than my attempt over in https://git.reviewb

Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-01-02 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/ --- Review request for KDE Frameworks. Repository: kitemviews Description -