Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-10-20 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/ --- (Updated Oct. 20, 2016, 12:05 p.m.) Status -- This change has been

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-24 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/#review91526 --- Ship it! - Yichao Yu On 一月 18, 2016, 11:48 a.m., René

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-18 Thread René J . V . Bertin
> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? > > Aleix Pol Gonzalez wrote: > KGlobalSettings is

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-18 Thread Yichao Yu
> On 一月 11, 2016, 10:17 a.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? > > Aleix Pol Gonzalez wrote: > KGlobalSettings is

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-18 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/ --- (Updated Jan. 18, 2016, 5:48 p.m.) Review request for KDE Software on

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-12 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/ --- (Updated Jan. 12, 2016, 10:40 p.m.) Review request for KDE Software on

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-11 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/#review90902 --- qt5/style/qtcurve_api.cpp (line 3211)

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-11 Thread René J . V . Bertin
> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? > > Aleix Pol Gonzalez wrote: > KGlobalSettings is

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-11 Thread Aleix Pol Gonzalez
> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? KGlobalSettings is deprecated in KF5. I recommend

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-11 Thread René J . V . Bertin
> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? > > Aleix Pol Gonzalez wrote: > KGlobalSettings is

Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Yichao Yu.