Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-08 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/ --- (Updated Jan. 8, 2016, 7:11 p.m.) Review request for KDE Frameworks,

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90808 --- Ship it! Ship It! - Marco Martin On Jan. 8, 2016, 7:11

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-08 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/ --- (Updated Jan. 8, 2016, 11:29 p.m.) Status -- This change has been

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Andreas Hartmetz
> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > > > > > What does the category have to do with this? We should only be going by > > the id (the plugin

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Sebastian Kügler
> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > > > > > What does the category have to do with this? We should only be going by > > the id (the plugin

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Andreas Hartmetz
> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > > > > > What does the category have to do with this? We should only be going by > > the id (the plugin

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Andreas Hartmetz
> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > Wouldn't it be way easier to simply check if the plugin is already in lst? > > > > Your approach looks very complex for just that... O(n) vs. O(n^2) - Andreas --- This is an