Review Request 126948: Simplify attica plugin look-up and initialization

2016-02-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/ --- Review request for KDE Frameworks. Repository: attica Description -

Re: Review Request 126948: Simplify attica plugin look-up and initialization

2016-02-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/ --- (Updated Feb. 1, 2016, 8:35 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 126948: Simplify attica plugin look-up and initialization

2016-02-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/ --- (Updated Feb. 1, 2016, 8:37 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 126948: Simplify attica plugin look-up and initialization

2016-02-01 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/#review91906 --- Ship it! Having custom lib loading code is not a good idea

Re: Review Request 126948: Simplify attica plugin look-up and initialization

2016-02-01 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/#review91908 --- Ship it! Ship It! - Jeremy Whiting On Feb. 1, 2016, 12:

Re: Review Request 126948: Simplify attica plugin look-up and initialization

2016-02-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/ --- (Updated Feb. 2, 2016, 2:06 a.m.) Status -- This change has been mar