Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-05-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated May 12, 2016, 8:57 a.m.) Status -- This change has been

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review95322 --- Ship it! Ship It! - David Faure On May 9, 2016, 9:06

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-05-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated Mai 9, 2016, 9:06 nachm.) Review request for KDE Frameworks and

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-05-09 Thread Kai Uwe Broulik
> On April 24, 2016, 1:57 nachm., David Faure wrote: > > Better, but I'm still wary of the reentrancy due to the nested event loop > > usage. > > > > I bet this leads to a complete deadlock: > > > > QTimer::singleShot(0, this, SLOT(launchConversion())); > > launchConversion(); > > >

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-05-06 Thread David Faure
> On April 24, 2016, 1:57 p.m., David Faure wrote: > > Better, but I'm still wary of the reentrancy due to the nested event loop > > usage. > > > > I bet this leads to a complete deadlock: > > > > QTimer::singleShot(0, this, SLOT(launchConversion())); > > launchConversion(); > > > >

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-04-24 Thread Kai Uwe Broulik
> On April 24, 2016, 1:57 nachm., David Faure wrote: > > Better, but I'm still wary of the reentrancy due to the nested event loop > > usage. > > > > I bet this leads to a complete deadlock: > > > > QTimer::singleShot(0, this, SLOT(launchConversion())); > > launchConversion(); > > >

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-04-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review94808 --- Better, but I'm still wary of the reentrancy due to the

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-04-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated April 24, 2016, 1:26 nachm.) Review request for KDE Frameworks

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-04-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review94447 --- src/currency.cpp (line 667)

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-04-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review94404 --- Ship it! Ship It! - David Edmundson On April 7, 2016,

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-04-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated April 7, 2016, 10 nachm.) Review request for KDE Frameworks and

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review93400 --- src/currency.cpp (line 661)

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated März 7, 2016, 2:35 nachm.) Review request for KDE Frameworks

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated März 7, 2016, 2:34 nachm.) Review request for KDE Frameworks

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review93183 --- I guess you couldn't trigger the mentionned crashes because

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-02 Thread Kai Uwe Broulik
> On März 2, 2016, 9 vorm., Ben Cooksley wrote: > > As a warning (because you'll be using QNAM here) please ensure you handle > > redirects properly and completely. Any software which fails to do so is > > considered unsupported even before it is released in regards to accessing > > KDE.org

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-02 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review93058 --- As a warning (because you'll be using QNAM here) please

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review93052 --- It's weird, I have a faint memory of this working during the

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated März 2, 2016, 12:48 vorm.) Review request for KDE Frameworks

Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- Review request for KDE Frameworks and Vishesh Handa. Bugs: 345750