Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-19 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127326/ --- (Updated Март 16, 2016, 11:33 след обяд) Status -- This change has

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-10 Thread Anthony Fieroni
> On Март 10, 2016, 3:56 след обяд, Martin Klapetek wrote: > > Can you please explain clearly the problem this should solve and explain > > more clearly how this solves that problem? > > > > Also I see with your every review "I have not tested this", please do test > > your patches before

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-10 Thread Martin Klapetek
> On March 10, 2016, 2:56 p.m., Martin Klapetek wrote: > > Can you please explain clearly the problem this should solve and explain > > more clearly how this solves that problem? > > > > Also I see with your every review "I have not tested this", please do test > > your patches before posting

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-10 Thread Anthony Fieroni
> On Март 10, 2016, 3:56 след обяд, Martin Klapetek wrote: > > Can you please explain clearly the problem this should solve and explain > > more clearly how this solves that problem? > > > > Also I see with your every review "I have not tested this", please do test > > your patches before

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127326/#review93387 --- Can you please explain clearly the problem this should solve

Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-10 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127326/ --- Review request for KDE Frameworks, Kai Uwe Broulik, David Edmundson, and