Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-07-02 Thread David Rosca
> On July 2, 2016, 8:26 a.m., David Faure wrote: > > src/kcmoduleqml.cpp, line 112 > > > > > > This line breaks compilation with Qt 5.4 (quickWindow() doesn't exist). > > > > > >

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/#review97002 --- src/kcmoduleqml.cpp (line 112)

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-05-20 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/ --- (Updated May 20, 2016, 3:33 p.m.) Status -- This change has been

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-05-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/#review95608 --- Ship it! I suggest we try it, then see if there are any

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread David Rosca
> On March 23, 2016, 12:07 p.m., Marco Martin wrote: > > In theory using QQuickWidget is the correct way, but... > > That widget is really not reliable, it has a structural (and probably > > unfixable at least on x11) problem in which anybody calling winId() > > anywhere on any window on the

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread Aleix Pol Gonzalez
> On March 23, 2016, 1:07 p.m., Marco Martin wrote: > > In theory using QQuickWidget is the correct way, but... > > That widget is really not reliable, it has a structural (and probably > > unfixable at least on x11) problem in which anybody calling winId() > > anywhere on any window on the

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/#review93895 --- In theory using QQuickWidget is the correct way, but... That

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/ --- (Updated March 23, 2016, 10:29 a.m.) Review request for KDE Frameworks.

Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/ --- Review request for KDE Frameworks. Bugs: 359124