Re: Review Request 127597: Fix generation of path to xcb plugin

2016-04-08 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/#review94420 --- Ship it! Ship It! - Heiko Becker On April 8, 2016,

Re: Review Request 127597: Fix generation of path to xcb plugin

2016-04-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/ --- (Updated April 8, 2016, 8:28 a.m.) Review request for KDE Frameworks.

Re: Review Request 127597: Fix generation of path to xcb plugin

2016-04-07 Thread Aleix Pol Gonzalez
> On April 7, 2016, 2:17 p.m., Heiko Becker wrote: > > Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be better suited > > to solve the relative/absolute PLUGINDIR issue? > > Martin Gräßlin wrote: > that generates a proper absolute path. I don't know about the relative > path,

Re: Review Request 127597: Fix generation of path to xcb plugin

2016-04-07 Thread Aleix Pol Gonzalez
> On April 7, 2016, 2:17 p.m., Heiko Becker wrote: > > Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be better suited > > to solve the relative/absolute PLUGINDIR issue? > > Martin Gräßlin wrote: > that generates a proper absolute path. I don't know about the relative > path,

Re: Review Request 127597: Fix generation of path to xcb plugin

2016-04-07 Thread Martin Gräßlin
> On April 7, 2016, 2:17 p.m., Heiko Becker wrote: > > Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be better suited > > to solve the relative/absolute PLUGINDIR issue? that generates a proper absolute path. I don't know about the relative path, though. - Martin

Re: Review Request 127597: Fix generation of path to xcb plugin

2016-04-07 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/#review94371 --- Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be

Re: Review Request 127597: Fix generation of path to xcb plugin

2016-04-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/#review94370 --- Ship it! Generating the path at compile time doesn't look

Re: Review Request 127597: Fix generation of path to xcb plugin

2016-04-07 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/#review94358 --- This is still not 100% correct. The define should be bullet

Review Request 127597: Fix generation of path to xcb plugin

2016-04-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/ --- Review request for KDE Frameworks. Repository: kwindowsystem