Re: Re[2]: Review Request 127632: Prioritize correct extension per theme

2016-04-26 Thread Aleix Pol
On Wed, Apr 27, 2016 at 12:58 AM, Nick Shaforostoff wrote: > sorry, I'm a bit late. I think having extensions without dots is preferred > from common sense POV: > > KDE-Extensions=svg > KDE-Extensions=svg,png > > what do you think? > > also, the spec would like additional params to start with X-,

Re[2]: Review Request 127632: Prioritize correct extension per theme

2016-04-26 Thread Nick Shaforostoff
sorry, I'm a bit late. I think having extensions without dots is preferred from common sense POV: KDE-Extensions=svg KDE-Extensions=svg,png what do you think? also, the spec would like additional params to start with X-, e.g. X-KDE-Extensions=svg X-KDE-Extensions=svg,png __

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/ --- (Updated April 27, 2016, 12:36 a.m.) Status -- This change has been

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94881 --- Ship it! Ship It! - Albert Astals Cid On April 26, 2016

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/ --- (Updated April 26, 2016, 10:51 p.m.) Review request for KDE Frameworks, A

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-26 Thread Aleix Pol Gonzalez
> On April 26, 2016, 10:02 p.m., Andreas Kainz wrote: > > Sorry someone add my but I can't follow the discussion. I don't know what > > this is doing. sorry. I wanted to make you aware of this change: `Needs patching in Breeze & Oxygen: https://paste.kde.org/py5kqvppv` - Aleix -

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-26 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94875 --- Sorry someone add my but I can't follow the discussion. I don

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94873 --- src/kicontheme.h (line 173)

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/ --- (Updated April 26, 2016, 9:12 p.m.) Review request for KDE Frameworks, An

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/ --- (Updated April 26, 2016, 5:42 p.m.) Review request for KDE Frameworks, An

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94851 --- +1 without patch strace kate |& grep ENOENT | wc -l 9369 str

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-22 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94759 --- Ship it! i think adhering spec here is not very important.

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-18 Thread Albert Astals Cid
> On April 11, 2016, 10:44 p.m., Albert Astals Cid wrote: > > I'm unconvinced, actually the spec mentions order to be "Changed search > > order to png, svg, xpm" > > Albert Astals Cid wrote: > > https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html > > Aleix P

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/ --- (Updated April 12, 2016, 1:17 a.m.) Review request for KDE Frameworks and

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-11 Thread Aleix Pol Gonzalez
> On April 12, 2016, 12:44 a.m., Albert Astals Cid wrote: > > I'm unconvinced, actually the spec mentions order to be "Changed search > > order to png, svg, xpm" > > Albert Astals Cid wrote: > > https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html I see, I di

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-11 Thread Albert Astals Cid
> On April 11, 2016, 10:44 p.m., Albert Astals Cid wrote: > > I'm unconvinced, actually the spec mentions order to be "Changed search > > order to png, svg, xpm" https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html - Albert -

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94547 --- I'm unconvinced, actually the spec mentions order to be "Chan

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94546 --- Ship it! Ship It! - David Edmundson On April 10, 2016,

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/ --- (Updated April 11, 2016, 1:05 a.m.) Review request for KDE Frameworks and

Review Request 127632: Prioritize correct extension per theme

2016-04-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth