Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-19 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/ --- Review request for KDE Frameworks and Lukáš Tinkl. Repository: solid De

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95629 --- This has been like this for years. Has any of the premises ch

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-19 Thread Michael Pyne
> On May 19, 2016, 10:30 p.m., Aleix Pol Gonzalez wrote: > > This has been like this for years. Has any of the premises changed? I think it's a good idea, if only to keep up with changes to the generated sources to account for things like undefined behavior fixes, fixes for new compiler warnin

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-19 Thread Pino Toscano
> On May 19, 2016, 10:30 p.m., Aleix Pol Gonzalez wrote: > > This has been like this for years. Has any of the premises changed? > > Michael Pyne wrote: > I think it's a good idea, if only to keep up with changes to the > generated sources to account for things like undefined behavior fixes

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Hannah von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95643 --- >From the windows side, we have flex and bison. +1 - Hannah

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95644 --- Looks good but I'll try to do a test-build during one of my n

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Pino Toscano
> On May 20, 2016, 8:39 a.m., René J.V. Bertin wrote: > > Looks good but I'll try to do a test-build during one of my next "lost > > moments". > > > > Is there a minimum required version for either of the parser/generators? > Is there a minimum required version for either of the parser/generat

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95657 --- I've done some testing with Solid 5.20.0 .The patch applies c

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95658 --- Ship it! Not only I approve of this change, but I also wis

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread René J . V . Bertin
> On May 21, 2016, 1:21 a.m., René J.V. Bertin wrote: > > I've done some testing with Solid 5.20.0 .The patch applies cleanly, but > > I'm getting the error below. I'd write that down to using the older Solid > > version if it weren't for that fact I'm quite sure I've seen this kind of > > err

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Pino Toscano
> On May 20, 2016, 11:21 p.m., René J.V. Bertin wrote: > > I've done some testing with Solid 5.20.0 .The patch applies cleanly, but > > I'm getting the error below. I'd write that down to using the older Solid > > version if it weren't for that fact I'm quite sure I've seen this kind of > > er

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Pino Toscano
> On May 20, 2016, 11:43 p.m., Nicolás Alvarez wrote: > > Not only I approve of this change, but I also wish it was done over all > > other KDE software using flex/bison. Yup, I will take care of othe cases like this one (they are just a few, luckly). - Pino

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-21 Thread René J . V . Bertin
> On May 21, 2016, 1:21 a.m., René J.V. Bertin wrote: > > I've done some testing with Solid 5.20.0 .The patch applies cleanly, but > > I'm getting the error below. I'd write that down to using the older Solid > > version if it weren't for that fact I'm quite sure I've seen this kind of > > err

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-21 Thread Pino Toscano
> On May 20, 2016, 11:21 p.m., René J.V. Bertin wrote: > > I've done some testing with Solid 5.20.0 .The patch applies cleanly, but > > I'm getting the error below. I'd write that down to using the older Solid > > version if it weren't for that fact I'm quite sure I've seen this kind of > > er

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-07-09 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/ --- (Updated July 10, 2016, 5:18 a.m.) Status -- This change has been ma