Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-25 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/#review96850 --- Cool, thanks Andreas! - Kevin Funk On June 24, 2016, 8:17

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-24 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/ --- (Updated June 24, 2016, 8:17 p.m.) Status -- This change has been

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/#review96846 --- Fix it, then Ship it! src/mainwindow.h (line 88)

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-24 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/ --- (Updated Juni 24, 2016, 4:14 nachm.) Review request for KDE Frameworks,

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/#review96832 --- You should also add a note in the

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-23 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/ --- (Updated Juni 23, 2016, 7:05 nachm.) Review request for KDE Frameworks,

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/#review96773 --- Would it be better to just have a setter and a member bool

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-21 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/#review96772 --- Rest LGTM src/mainwindow.cpp (line 81)