Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2017-02-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/ --- (Updated March 1, 2017, 2:33 a.m.) Status -- This change has been di

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-12 Thread Martin Gräßlin
> On July 12, 2016, 8:07 a.m., Martin Gräßlin wrote: > > What about shader variants for GLES? There are also two versions, one being > > like the old one and one like core. In KWin we can handle this with the > > same shader code and rewriting e.g. the version statement. Do you know how > > th

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-12 Thread David Edmundson
> On July 12, 2016, 6:07 a.m., Martin Gräßlin wrote: > > What about shader variants for GLES? There are also two versions, one being > > like the old one and one like core. In KWin we can handle this with the > > same shader code and rewriting e.g. the version statement. Do you know how > > th

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/#review97302 --- What about shader variants for GLES? There are also two versi

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/#review97299 --- Looks like an interesting optimization oportunity! :) src/d

Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor