Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/ --- (Updated July 22, 2016, 10:09 p.m.) Status -- This change has been

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-22 Thread David Faure
> On July 21, 2016, 9:52 p.m., David Faure wrote: > > src/filewidgets/knewfilemenu.cpp, line 497 > > > > > > I don't follow. Doesn't removing this connect, break the case of > > desktop files not from a

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-21 Thread Chinmoy Ranjan Pradhan
> On July 21, 2016, 9:52 p.m., David Faure wrote: > > Did you check if knewfilemenutest still passes? > > > > I see that it's not testing the properties dialog case, I'm working on that. > > > > (Maybe it would have been easier to split this into 3 different commits & > > review requests, if

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/#review97725 --- Did you check if knewfilemenutest still passes? I see that

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-21 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/ --- (Updated July 21, 2016, 4:30 p.m.) Review request for KDE Frameworks and

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-20 Thread Chinmoy Ranjan Pradhan
> On July 19, 2016, 5:29 p.m., David Faure wrote: > > src/filewidgets/knewfilemenu.cpp, line 789 > > > > > > The QFile::exists check is redundant. QFile::remove will do nothing if > > the file doesn't exist. >

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-20 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/ --- (Updated July 20, 2016, 7:09 a.m.) Review request for KDE Frameworks and

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-19 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/ --- (Updated July 19, 2016, 5:30 p.m.) Review request for KDE Frameworks and