Re: Review Request 128488: Add a fallback method for query_qmake() when there's no Qt5 installation

2016-07-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128488/ --- (Updated July 26, 2016, 12:07 p.m.) Status -- This change has been

Re: Review Request 128488: Add a fallback method for query_qmake() when there's no Qt5 installation

2016-07-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128488/#review97851 --- Ship it! Ship It! - David Faure On July 26, 2016,

Re: Review Request 128488: Add a fallback method for query_qmake() when there's no Qt5 installation

2016-07-25 Thread Aleix Pol Gonzalez
> On July 21, 2016, 1:55 p.m., David Faure wrote: > > modules/ECMQueryQmake.cmake, line 14 > > > > > > If query_qmake isn't public API, it's not what the cmakelists.txt is > > calling. So it looks like an

Re: Review Request 128488: Add a fallback method for query_qmake() when there's no Qt5 installation

2016-07-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128488/ --- (Updated July 26, 2016, 2:12 a.m.) Review request for Extra Cmake

Re: Review Request 128488: Add a fallback method for query_qmake() when there's no Qt5 installation

2016-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128488/#review97710 --- modules/ECMQueryQmake.cmake (line 14)

Review Request 128488: Add a fallback method for query_qmake() when there's no Qt5 installation

2016-07-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128488/ --- Review request for Extra Cmake Modules, KDE Frameworks and David Faure.