Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-08-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/ --- (Updated Aug. 2, 2016, 6:14 p.m.) Status -- This change has been mar

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-08-02 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/#review98004 --- Ship it! He, this is the very same patch that I found in t

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-29 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/#review97915 --- Ship it! Ship It! - Sune Vuorela On July 24, 2016, 9:14

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-24 Thread David Faure
> On July 24, 2016, 9:26 p.m., Friedrich W. H. Kossebau wrote: > > Please also try those other smoke unit tests. > > I do not remember things detailed right now, but possibly > > `resetInternalData();` resulted in lots of signal emitted due to > > rowinserted or something, which broke at least

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-24 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/#review97808 --- Please also try those other smoke unit tests. I do not rememb

Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/ --- Review request for KDE Frameworks, Friedrich W. H. Kossebau, Stephen Kelly,