Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128843/ --- (Updated Sept. 6, 2016, 4:17 p.m.) Status -- This change has been ma

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128843/#review98937 --- Ship it! Ship It! - Lamarque Souza On Sept. 6, 2016, 11

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
> On Zář. 6, 2016, 12:01 odp., Lamarque Souza wrote: > > > > Jan Grulich wrote: > Every DeviceType inherits from Device, same as DeviceTypePrivate inherits > from DevicePrivate so when DeviceType is connected to PropertiesChanged > signal and doesn't implement the slot itself, then it will

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
> On Zář. 6, 2016, 12:01 odp., Lamarque Souza wrote: > > Every DeviceType inherits from Device, same as DeviceTypePrivate inherits from DevicePrivate so when DeviceType is connected to PropertiesChanged signal and doesn't implement the slot itself, then it will call the DevicePrivate::dbusPro

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128843/#review98930 --- src/adsldevice.cpp (line 46)

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128843/#review98931 --- Ignore please the changed debug outputs, I already reverted t

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128843/ --- (Updated Zář. 6, 2016, 11:56 dop.) Review request for KDE Frameworks, Net

Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

2016-09-06 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128843/ --- Review request for KDE Frameworks, Network Management and Lamarque Souza.