Re: Review Request 128855: Fix build on Windows

2016-09-08 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128855/ --- (Updated Sept. 8, 2016, 4:27 a.m.) Status -- This change has been

Re: Review Request 128855: Fix build on Windows

2016-09-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128855/#review98993 --- Ship it! Ship It! - Kevin Funk On Sept. 7, 2016, 3:23

Re: Review Request 128855: Fix build on Windows

2016-09-07 Thread Gleb Popov
> On Sept. 7, 2016, 9:24 p.m., Kevin Funk wrote: > > `kioglobal_p.h` defines those. Just include that one? Yep, you are right, this fixes build too. Ok to commit this one-liner? ``` + #include "kioglobal_p.h" ``` - Gleb --- This is an

Re: Review Request 128855: Fix build on Windows

2016-09-07 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128855/#review98981 --- `kioglobal_p.h` defines those. Just include that one? -

Review Request 128855: Fix build on Windows

2016-09-07 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128855/ --- Review request for KDE Frameworks. Repository: kio Description ---