Re: Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/ --- (Updated Feb. 8, 2017, 2:25 nachm.) Status -- This change has been

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 27, 2016, 7:39 a.m., Martin Gräßlin wrote: > > Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding > > to ECM > > David Edmundson wrote: > To this specific patch, or the concept in general? To this specific patch - Martin

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 27, 2016, 5:39 a.m., Martin Gräßlin wrote: > > Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding > > to ECM To this specific patch, or the concept in general? - David --- This is an automatically

Re: Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100323 --- Due to https://git.reviewboard.kde.org/r/129268/ I'm giving

Re: Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/ --- (Updated Okt. 26, 2016, 9:17 vorm.) Review request for KDE Frameworks,

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote: > > find-modules/FindQt5PlatformSupport.cmake, line 75 > > > > > > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and > >

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Okt. 25, 2016, 11:31 vorm., Hrvoje Senjan wrote: > > find-modules/FindQt5PlatformSupport.cmake, line 75 > > > > > > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and > >

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote: > > find-modules/FindQt5PlatformSupport.cmake, line 75 > > > > > > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and > >

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 11:37 a.m., Aleix Pol Gonzalez wrote: > > Shouldn't this be in Qt? What am I missing? > > Martin Gräßlin wrote: > Yes it should, but it isn't. No idea why not. > > Hrvoje Senjan wrote: > The module is internal, so it intentionally doesn't install any cmake > files.

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 1:37 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't this be in Qt? What am I missing? > > Martin Gräßlin wrote: > Yes it should, but it isn't. No idea why not. The module is internal, so it intentionally doesn't install any cmake files. - Hrvoje

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Okt. 25, 2016, 11:31 vorm., Hrvoje Senjan wrote: > > find-modules/FindQt5PlatformSupport.cmake, line 75 > > > > > > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and > >

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 1:37 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't this be in Qt? What am I missing? Yes it should, but it isn't. No idea why not. - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100257 --- Shouldn't this be in Qt? What am I missing? - Aleix Pol

Re: Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100256 --- find-modules/FindQt5PlatformSupport.cmake (line 75)

Re: Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100255 --- +1 - Martin Gräßlin On Oct. 25, 2016, 1:21 p.m., Kai Uwe

Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/ --- Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.