Re: Review Request 129280: Fix editing autostart items

2016-10-31 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/ --- (Updated Oct. 31, 2016, 8:37 p.m.) Status -- This change has been

Re: Review Request 129280: Fix editing autostart items

2016-10-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/#review100415 --- Ship it! You could improve performance by using the same

Re: Review Request 129280: Fix editing autostart items

2016-10-30 Thread Antonio Rojas
> On Oct. 30, 2016, 10:20 a.m., David Faure wrote: > > src/widgets/kpropertiesdialog.cpp, line 1242 > > > > > > But this returns the *parent* of base, right? > > > > I guess what we need here is rather

Re: Review Request 129280: Fix editing autostart items

2016-10-30 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/ --- (Updated Oct. 30, 2016, 10:36 p.m.) Review request for KDE Frameworks

Re: Review Request 129280: Fix editing autostart items

2016-10-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/#review100390 --- src/widgets/kpropertiesdialog.cpp (line 1242)

Review Request 129280: Fix editing autostart items

2016-10-28 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/ --- Review request for KDE Frameworks and David Faure. Bugs: 371194