Review Request 129315: Don't install plasmoid desktop files as services

2016-11-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 129315: Don't install plasmoid desktop files as services

2016-11-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/#review100537 --- I'm in favor of this, let's wait to 5.29 tough - Marco Mart

Re: Review Request 129315: Don't install plasmoid desktop files as services

2016-11-06 Thread David Faure
> On Nov. 3, 2016, 12:53 p.m., Marco Martin wrote: > > I'm in favor of this, let's wait to 5.29 tough 5.28 RC is tagged, you can now push commits for 5.29. - David --- This is an automatically generated e-mail. To reply, visit: https://

Re: Review Request 129315: Don't install plasmoid desktop files as services

2016-11-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/#review100678 --- Ship it! Ship It! - Marco Martin On Nov. 3, 2016, 1:06

Re: Review Request 129315: Don't install plasmoid desktop files as services

2016-11-07 Thread Marco Martin
> On Nov. 3, 2016, 12:53 p.m., Marco Martin wrote: > > I'm in favor of this, let's wait to 5.29 tough > > David Faure wrote: > 5.28 RC is tagged, you can now push commits for 5.29. thanks! - Marco --- This is an automatically gener

Re: Review Request 129315: Don't install plasmoid desktop files as services

2017-01-23 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/#review102223 --- Any reason this has not been committed? - Albert Astals Cid

Re: Review Request 129315: Don't install plasmoid desktop files as services

2017-01-23 Thread Aleix Pol Gonzalez
> On Jan. 23, 2017, 8:10 p.m., Albert Astals Cid wrote: > > Any reason this has not been committed? Yes, IIRC the KService usage in KRunner was reintroduced. We need to retest the patch now. - Aleix --- This is an automatically generat

Re: Review Request 129315: Don't install plasmoid desktop files as services

2017-02-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/ --- (Updated Feb. 8, 2017, 3:37 p.m.) Status -- This change has been dis