Re: Review Request 129590: KAuth: Make D-Bus dependency optional.

2017-10-07 Thread David Faure
On lundi 17 juillet 2017 11:21:29 CEST Ralf Habacker wrote: > -target_link_libraries(KF5Auth PRIVATE Qt5::Widgets Qt5::DBus) > +target_link_libraries(KF5Auth PRIVATE Qt5::Widgets ${DBUS_LIBRARY}) If this means KAuth doesn't use DBus (on some platforms), then the proper fix would be to only link

Re: Review Request 129590: KAuth: Make D-Bus dependency optional.

2017-07-17 Thread Ralf Habacker
> On Jan. 8, 2017, 6:53 nachm., David Faure wrote: > > autotests/CMakeLists.txt, line 5 > > > > > > Better split this into two, to avoid confusing people. I've update the patch, but do not have access rights to

Re: Review Request 129590: KAuth: Make D-Bus dependency optional.

2017-01-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129590/#review101885 --- Looks good, just one comment. autotests/CMakeLists.txt

Review Request 129590: KAuth: Make D-Bus dependency optional.

2016-11-30 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129590/ --- Review request for KDE Frameworks and kdewin. Repository: kauth