Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-28 Thread Elvis Angelaccio
> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? > https://api.kde.org/frameworks/kdelibs4support/html/classKBut

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/ --- (Updated Dec. 28, 2016, 11:05 a.m.) Status -- This change has been d

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/#review101623 --- src/kconfigdialogmanager.cpp

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Albert Astals Cid
> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? > https://api.kde.org/frameworks/kdelibs4support/html/classKBut

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Elvis Angelaccio
> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? > https://api.kde.org/frameworks/kdelibs4support/html/classKBut

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Anthony Fieroni
> On Дек. 27, 2016, 11:16 след обяд, Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? > https://api.kde.org/frameworks/kdelibs4support/html/cla

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Elvis Angelaccio
> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? > https://api.kde.org/frameworks/kdelibs4support/html/classKBut

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Elvis Angelaccio
> On Dec. 27, 2016, 9:18 p.m., Christoph Feck wrote: > > className() is just a char pointer. Is it possible to convert the maps to > > not use QString? I don't think so, they are public api, e.g. `static QHash *changedMap();` - Elvis

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Elvis Angelaccio
> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. Why? Isn't it deprecated? https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html - Elvis --

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/#review101612 --- className() is just a char pointer. Is it possible to conver

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/#review101610 --- -1 Don't break what is not broken. First thing i check "KBu

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/#review101606 --- Ping? - Elvis Angelaccio On Dec. 16, 2016, 3:05 p.m., Elv

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-16 Thread Elvis Angelaccio
> On Dec. 16, 2016, 3:55 p.m., Aleix Pol Gonzalez wrote: > > +1 > > Would it be possible to do the same with the signals? Unfortunately that would break compatibility (the maps are public and clients can insert new stuff there) - Elvis ---

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/#review101471 --- +1 Would it be possible to do the same with the signals? -

Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-16 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti