---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129724/
---
Review request for Build System and KDE Frameworks.
Repository: extra-cma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129724/#review101662
---
Ship it!
LGTM, and the Clang equivalent (-Winconsistent-m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129724/
---
(Updated Dec. 29, 2016, 11:48 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129724/#review101664
---
Is that enabled by default now? I hope not! This is a comple
> On Dec. 30, 2016, 6:39 a.m., Martin Gräßlin wrote:
> > Is that enabled by default now? I hope not! This is a completely useless
> > warning for all frameworks (as we are not allowed to use override) and even
> > more for a legacy code bases. I don't want to have to adjust the cmake in
> > al
> On Dez. 30, 2016, 7:39 vorm., Martin Gräßlin wrote:
> > Is that enabled by default now? I hope not! This is a completely useless
> > warning for all frameworks (as we are not allowed to use override) and even
> > more for a legacy code bases. I don't want to have to adjust the cmake in
> > a
> On Dec. 30, 2016, 6:39 a.m., Martin Gräßlin wrote:
> > Is that enabled by default now? I hope not! This is a completely useless
> > warning for all frameworks (as we are not allowed to use override) and even
> > more for a legacy code bases. I don't want to have to adjust the cmake in
> > al
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129724/#review101822
---
Note: This got reverted in master for now, since there were
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129724/#review102057
---
@Stephen: Let's re-introduce this patch? Laurent + me have a
> On Jan. 16, 2017, 8:53 a.m., Kevin Funk wrote:
> > @Stephen: Let's re-introduce this patch? Laurent + me have applied
> > `Q_DECL_OVERRIDE` everywhere. Do you want to double-check?
Sorry, I didn't get pinged by email about this, despite the mention from Albert
below. Re-applying this sounds
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129724/
---
(Updated Jan. 23, 2017, 7:04 p.m.)
Status
--
This change has been ma
11 matches
Mail list logo