Re: kemoticons unittests broken

2015-08-01 Thread kainz.a
I will have a look, but the "problem" is that the artist freeze is in a few days and I have to push some updates for the icon set and also have to make some new icons so if you work on that, it would be really nice. When I have time I will have a look and will see how kde will make the tests. than

Re: kemoticons unittests broken

2015-08-01 Thread kainz.a
Hi, I have no glue how I can fix it, could you please look into the problem. thanks Andreas Kainz 2015-08-01 20:32 GMT+02:00 David Faure : > Hello Andreas, > > in commit 6fa213952ed0a7eee18a90c4f326d9312027788a you changed the > default theme in kemoticons. > > Did you check that unittets still

Re: kemoticons unittests broken

2015-08-01 Thread David Faure
On Saturday 01 August 2015 21:32:39 David Faure wrote: > So this is likely just a case of updating the expected values in git. ... or maybe a better idea: forcing the unittests to use breeze, so that they don't depend on the choice of default theme... -- David Faure, fa...@kde.org, http://www.d

Re: kemoticons unittests broken

2015-08-01 Thread David Faure
On Saturday 01 August 2015 21:04:38 kainz.a wrote: > Hi, > > I have no glue how I can fix it, could you please look into the problem. It's not that hard, you ensure the test is compiled (pass -DBUILD_TESTING=TRUE to cmake) then you run the test (cd autotest ; ./kemoticons-kemoticontest) then you

kemoticons unittests broken

2015-08-01 Thread David Faure
Hello Andreas, in commit 6fa213952ed0a7eee18a90c4f326d9312027788a you changed the default theme in kemoticons. Did you check that unittets still pass? https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/13/console Please look into fixing the unit tests as soon as