khtml uses qx11info_x11 without checking for qtx11support

2013-02-10 Thread Treeve Jelbert
/var/git/kf5/khtml/khtmlview.cpp:36:26: fatal error: qx11info_x11.h: No such file or directory compilation terminated. Also qtx11support is broken, still uses obsolete QT_{BEGIN,END}_HEADER ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde

Re: khtml uses qx11info_x11 without checking for qtx11support

2013-02-10 Thread Stephen Kelly
Treeve Jelbert wrote: > /var/git/kf5/khtml/khtmlview.cpp:36:26: fatal error: qx11info_x11.h: No > such file or directory > compilation terminated. > > Also qtx11support is broken, still uses obsolete QT_{BEGIN,END}_HEADER Please make sure you are using codereview.qt-project.org:qt/qtx11extras.

Re: khtml uses qx11info_x11 without checking for qtx11support

2013-02-10 Thread David Faure
On Sunday 10 February 2013 09:33:45 Treeve Jelbert wrote: > /var/git/kf5/khtml/khtmlview.cpp:36:26: fatal error: qx11info_x11.h: No > such file or directory > compilation terminated. Fixed. > Also qtx11support is broken, still uses obsolete QT_{BEGIN,END}_HEADER What's qtx11support? Do you mean

Re: khtml uses qx11info_x11 without checking for qtx11support

2013-02-10 Thread Alexander Neundorf
On Sunday 10 February 2013, Stephen Kelly wrote: > Treeve Jelbert wrote: > > /var/git/kf5/khtml/khtmlview.cpp:36:26: fatal error: qx11info_x11.h: No > > such file or directory > > compilation terminated. > > > > Also qtx11support is broken, still uses obsolete QT_{BEGIN,END}_HEADER > > Please mak

Re: khtml uses qx11info_x11 without checking for qtx11support

2013-02-10 Thread Alexander Neundorf
On Sunday 10 February 2013, Stephen Kelly wrote: > Treeve Jelbert wrote: > > /var/git/kf5/khtml/khtmlview.cpp:36:26: fatal error: qx11info_x11.h: No > > such file or directory > > compilation terminated. > > > > Also qtx11support is broken, still uses obsolete QT_{BEGIN,END}_HEADER > > Please mak

Re: khtml uses qx11info_x11 without checking for qtx11support

2013-02-10 Thread Stephen Kelly
Alexander Neundorf wrote: > On Sunday 10 February 2013, Stephen Kelly wrote: >> Treeve Jelbert wrote: >> > /var/git/kf5/khtml/khtmlview.cpp:36:26: fatal error: qx11info_x11.h: No >> > such file or directory >> > compilation terminated. >> > >> > Also qtx11support is broken, still uses obsolete QT

Re: khtml uses qx11info_x11 without checking for qtx11support

2013-02-10 Thread David Faure
On Sunday 10 February 2013 15:51:35 Alexander Neundorf wrote: > On Sunday 10 February 2013, Stephen Kelly wrote: > > Treeve Jelbert wrote: > > > /var/git/kf5/khtml/khtmlview.cpp:36:26: fatal error: qx11info_x11.h: No > > > such file or directory > > > compilation terminated. > > > > > > Also qtx11

Re: khtml uses qx11info_x11 without checking for qtx11support

2013-02-11 Thread David Faure
On Sunday 10 February 2013 23:35:53 Stephen Kelly wrote: > Especially as I see on the wiki link you posted, the recommendation is to > configure it with tests. Why do we instruct people build all Qt tests? > That's pure timewasting. OK, I guess not everyone compiling KF5 will contribute to Qt as

Re: khtml uses qx11info_x11 without checking for qtx11support

2013-02-11 Thread Stephen Kelly
David Faure wrote: > On Sunday 10 February 2013 23:35:53 Stephen Kelly wrote: >> Especially as I see on the wiki link you posted, the recommendation is to >> configure it with tests. Why do we instruct people build all Qt tests? >> That's pure timewasting. > > OK, I guess not everyone compiling K