kio and scheme://

2014-11-02 Thread Àlex Fiestas
Hi there There are quite a few places where the following code is found: if (!url.path().endsWith('/')) { url.setPath(url.path() + '/'); } Given an url like: 'scheme://' KUrl will return '/' as path while QUrl returns empty string. This is making kio add a third slash to the url in many pl

Re: kio and scheme://

2014-11-02 Thread Milian Wolff
On Sunday 02 November 2014 13:43:50 Àlex Fiestas wrote: > Hi there > > There are quite a few places where the following code is found: > > if (!url.path().endsWith('/')) { > url.setPath(url.path() + '/'); > } Unrelated to the below, this will also add a trailing slash to non-empty paths, pr

Re: kio and scheme://

2014-11-04 Thread David Faure
On Sunday 02 November 2014 13:43:50 Àlex Fiestas wrote: > Hi there > > There are quite a few places where the following code is found: > > if (!url.path().endsWith('/')) { > url.setPath(url.path() + '/'); > } Right. > Given an url like: 'scheme://' KUrl will return '/' as path Wrong. htt

Re: kio and scheme://

2014-11-04 Thread David Faure
On Sunday 02 November 2014 23:23:55 Milian Wolff wrote: > On Sunday 02 November 2014 13:43:50 Àlex Fiestas wrote: > > Hi there > > > > There are quite a few places where the following code is found: > > > > if (!url.path().endsWith('/')) { > > > > url.setPath(url.path() + '/'); > > > > } >

Re: kio and scheme://

2015-02-15 Thread Àlex Fiestas
On Tuesday 04 November 2014 21:47:36 you wrote: > On Sunday 02 November 2014 13:43:50 Àlex Fiestas wrote: > > Hi there > > > > There are quite a few places where the following code is found: > > > > if (!url.path().endsWith('/')) { > > > > url.setPath(url.path() + '/'); > > > > } > > Right

Re: kio and scheme://

2015-02-15 Thread Mark Gaiser
On Sun, Feb 15, 2015 at 8:00 PM, Àlex Fiestas wrote: > On Tuesday 04 November 2014 21:47:36 you wrote: > > On Sunday 02 November 2014 13:43:50 Àlex Fiestas wrote: > > > Hi there > > > > > > There are quite a few places where the following code is found: > > > > > > if (!url.path().endsWith('/'))

Re: kio and scheme://

2015-02-17 Thread Àlex Fiestas
Review request to fix this! https://git.reviewboard.kde.org/r/122613/ Thanks for the support guys! On Sun, Nov 2, 2014 at 1:43 PM, Àlex Fiestas wrote: > Hi there > > There are quite a few places where the following code is found: > > if (!url.path().endsWith('/')) { > url.setPath(url.path()