KDE CI: Frameworks » kded » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kded/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:10 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KDED-5.69.0.xml

KDE CI: Frameworks » kemoticons » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kemoticons/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:10 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcompletion » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcompletion/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:10 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kmediaplayer » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kmediaplayer/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 14 min and counting BUILD ARTIFACTS

D28325: [Inotify] Call QFile::decode only in a single place

kossebau added inline comments. INLINE COMMENTS > kinotify.cpp:368 > +uint32_t fileEvents = EventAll & ~(EventMoveFrom | > EventQueueOverflow | EventIgnored); > +const QString fname = event->mask & fileEvents ? > QFile::decodeName(path) : QString(); > + For better code

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kplotting » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:11 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:09 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:12 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » attica » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:12 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.14 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:12 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:13 + Build duration: 23 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemviews » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:14 + Build duration: 23 min and counting BUILD ARTIFACTS

D28349: Fix Warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R244:fcdf263339b4: Fix Warnings (authored by meven). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28349?vs=78655=78656 REVISION DETAIL

KDE CI: Frameworks » kactivities-stats » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kactivities-stats/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:13 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 174 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/174/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 27 Mar 2020 14:45:48 + Build duration: 5 min 38 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdbusaddons » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdbusaddons/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:15 + Build duration: 29 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:15 + Build duration: 28 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:14 + Build duration: 30 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:15 + Build duration: 30 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:15 + Build duration: 31 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwallet » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:15 + Build duration: 30 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kglobalaccel » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:19 + Build duration: 35 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » threadweaver » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20SUSEQt5.14/1/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 14:22:19 + Build duration: 35 min and counting BUILD ARTIFACTS

D28295: Introduce KNotificationJobUiDelegate

broulik updated this revision to Diff 78644. broulik added a comment. - Fix docs REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28295?vs=78520=78644 REVISION DETAIL https://phabricator.kde.org/D28295 AFFECTED FILES src/CMakeLists.txt

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

dfaure added inline comments. INLINE COMMENTS > commandlauncherjobtest.cpp:99 > + > +void CommandLauncherJobTest::doesNotFailOnNonExistingExecutable() > +{ See this unittest ;-) As the comment says, QProcess works since it manages to start /bin/sh. We don't want to wait until the

D28336: Drop klauncher usage from KCrash

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY As per other discussions, kdeinit has limited gains and is not widely deployed in KDE application.

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

broulik added a comment. One thing I noticed, when I do `new CommandLaunchJob("somenonexistantbinary")` no error is raised and I just get console output `/bin/sh: 1: somenonexistantbinary: not found Though this was also the case of `runCommand`, so maybe not an issue. REPOSITORY

D28295: Introduce KNotificationJobUiDelegate

nicolasfella added inline comments. INLINE COMMENTS > knotificationjobuidelegate.h:29 > + * > + * A UI delegate using KMessageBox for interaction (showing errors and > warnings). > + * s/KMessageBox/KNotification/g? REPOSITORY R289 KNotifications REVISION DETAIL

D28295: Introduce KNotificationJobUiDelegate

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Otherwise looks good to me INLINE COMMENTS > knotificationjobuidelegate.h:28 > + * @class KNotificationJobUiDelegate knotificationjobuidelegate.h > KNotificationJobUiDelegate

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 78698. ervin marked 10 inline comments as done. ervin added a comment. Addresses Kai and David comments. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=78469=78698 REVISION DETAIL

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin updated this revision to Diff 78703. ervin added a comment. As advised by Kai and David on D27840 , switch to using tool buttons and fix RTL handling. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a reviewer: broulik. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28355: Introduce function ecm_install_configured_file

davidedmundson updated this revision to Diff 78693. davidedmundson added a comment. Good idea. Done REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28355?vs=78678=78693 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28355

D28359: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze-Icons

paulm added a task: T12793: 'Classik' KDE1-like titlebar button icon style replacing Breeze's unorthodox 'Oxygen' style. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28359 To: paulm, #vdg, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28268: KDesktopFileActions: port from KRun::run to KIO::ApplicationLauncherJob

dfaure added a dependency: D28367: KServiceAction: store parent service. REPOSITORY R241 KIO BRANCH kdesktopfileactions REVISION DETAIL https://phabricator.kde.org/D28268 To: dfaure, davidedmundson, apol, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28367: KServiceAction: store parent service

dfaure added a dependent revision: D28268: KDesktopFileActions: port from KRun::run to KIO::ApplicationLauncherJob. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D28367 To: dfaure, broulik, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28268: KDesktopFileActions: port from KRun::run to KIO::ApplicationLauncherJob

dfaure updated this revision to Diff 78710. dfaure edited the summary of this revision. dfaure added a comment. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Rebase on D28367 , remove KService::Ptr arg REPOSITORY

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. Cannot reproduce, it looks like what's in the screenshots to me. Just for sure, I also added the dep on Nate's patch as that improves legibility. I totally agree on your points seen what you got, that'd be extreme. With what I'm actually trying to propose (I don't

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 50% transparency, while rating has 100% opacity? That makes my compare script go wild, and I think it doesn’t look intended. TASK DETAIL https://phabricator.kde.org/T12855 To:

D28367: KServiceAction: store parent service

dfaure created this revision. dfaure added reviewers: broulik, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This allows KIO::ApplicationLauncherJob to find the icon and name of

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. Bug! It should look like this: F8201997: Screenshot_20200327_191850.png Let me check again. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma,

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

dfaure added a comment. Makes sense. But in many places, having to provide both is problematic. E.g. when the KServiceAction is the value<>() of a QAction. I'll look into storing the KService::Ptr inside the KServiceAction. If this works out, we can remove the KService::Ptr argument

D28266: KPropertiesDialog: port KRun::run to ApplicationLauncherJob

dfaure added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28266 To: dfaure, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 78691. trmdi added a comment. Improve the logic a bit. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=78427=78691 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 502 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/502/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 27 Mar 2020 21:32:54 + Build duration: 5 min 50 sec and counting BUILD ARTIFACTS

D28355: Introduce function ecm_install_configured_file

pino added a comment. Nice one! I cannot test right now though, I might do it over the weekend (do not hold on me though). I took the liberty of doing some formatting changes to the header of the new file, what do you think? #.rst: # ECMConfiguredInstall #

D27840: Introduce SettingState* elements to ease KCM writing

ervin marked 15 inline comments as done. ervin added inline comments. INLINE COMMENTS > broulik wrote in SettingStateBinding.qml:58 > This description didn't really help me in understanding what it does until I > read the code further down. Went for something much more verbose, but at least it

D28362: Fix stylesheet linking in 8 icons

davidhurka updated this revision to Diff 78701. davidhurka added a subscriber: ndavis. davidhurka added a comment. @ndavis REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28362?vs=78700=78701 BRANCH fix-some-style-attributes REVISION DETAIL

D28362: Fix stylesheet linking in 8 icons

davidhurka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY These 8 icons were (partially) not recolored by the stylesheet, because their elements were either not linked to

D28362: Fix stylesheet linking in 8 icons

davidhurka updated this revision to Diff 78702. davidhurka added a comment. - Fix spelling REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28362?vs=78701=78702 BRANCH fix-some-style-attributes REVISION DETAIL https://phabricator.kde.org/D28362

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. niccolove added a dependency: D28317: Adjust default color scheme and titlebar appearance for Tools Area. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack, ngraham Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25315: KDirModel: implement showing a root node for the requested URL

rrosch added a comment. Tested, no crashes, it works as intended, and it is beautiful! Thank you! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25315 To: dfaure, stefanocrocco, elvisangelaccio, meven, apol Cc: rrosch, ahmadsamir, kde-frameworks-devel, LeGast00n,

D28355: Introduce function ecm_install_configured_file

kossebau added a comment. A .rst file in the docs/module/ directory is needed, otherwise the documentation generation will not pick up this, as it runs only over docs/. Please enable the documentation generation in your ecm build and check for yourself, by e.g. ensuring `BUILD_HTML_DOCS`

D28355: Introduce function ecm_install_configured_file

pino added inline comments. INLINE COMMENTS > davidedmundson wrote in ECMConfiguredInstall.cmake:46-48 > Maybe. > > My rationale for not forcing a suffix is sometimes we do this configure dance > for .desktop files and there we have to be a bit careful with scripty. > > But generally it's

D28355: Introduce function ecm_install_configured_file

davidedmundson added inline comments. INLINE COMMENTS > pino wrote in ECMConfiguredInstall.cmake:46-48 > considering we are documenting the input file as `.cmake.in`, should we > enforce this here and ignore any file not ending like that? Maybe. My rationale for not forcing a suffix is

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I see some problems here. To be honest, the level of transparency is way too high. I know aesthetics are subjective, but it just doesn't look good to me. Even with our

D28324: [Inotify] Remove dead/duplicate code

pino added inline comments. INLINE COMMENTS > bruns wrote in kinotify.cpp:350 > asserts are IMHO pointless, nobody enables them, but it clutters the code. > Anyone touching the code should and has to read the man pages etc anyway. no, an assert is sort of "program by contract": you make it

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack requested changes to this revision. cblack added a comment. I've changed my mind to agree with @ngraham here—this is too transparent. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack, ngraham Cc:

D28359: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze-Icons

paulm created this revision. paulm added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. paulm requested review of this revision. REVISION SUMMARY As described in T12793 , this patch applies the

D28324: [Inotify] Remove dead/duplicate code

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > pino wrote in kinotify.cpp:350 > no, an assert is sort of "program by contract": you make it clear that this > situation ought to not happen, and it if does, at least some people may > notice that > > >

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#636164 , @cblack wrote: > Looks visually appealing to me, with one question: How does this look on low-end hardware where there's compositing but no blur? Before: F8201840:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack added a comment. In D28353#636183 , @niccolove wrote: > In D28353#636164 , @cblack wrote: > > > Looks visually appealing to me, with one question: How does this look on low-end hardware

D28221: Don't write default value to configuration file when default value came from /etc/* file

ervin requested changes to this revision. ervin added inline comments. INLINE COMMENTS > kconfigskeletontest.cpp:25 > > +static inline QString kdeGlobalsPath() { > +return > QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) + > "/kdeglobals"; { should be on its own

D28355: Introduce function ecm_install_configured_file

pino added a comment. Can you please adapt it so `_template` can be an absolute path? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson Cc: pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh,

D28324: [Inotify] Remove dead/duplicate code

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > pino wrote in kinotify.cpp:350 > then add an assert for this case, referencing the documentation? asserts are IMHO pointless, nobody enables them, but it clutters the code. Anyone touching the code should

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY (gimme a sec to edit with screenshots) REPOSITORY R242 Plasma Framework (Library) BRANCH

D28128: Add force save behavior to KEntryMap

ervin added inline comments. INLINE COMMENTS > kconfigtest.cpp:1953 > + > +void KConfigTest::testKdeglobalsVSDefault() > +{ Seeing how this test confuses everyone (including me and I knew the problem before hand...), I think it'd benefit greatly from getting comments at the most important

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove updated this revision to Diff 78675. niccolove added a comment. Fix breeze dark values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28353?vs=78668=78675 BRANCH contrast_and_transparency (branched from master) REVISION

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack accepted this revision as: VDG, cblack. cblack added a comment. This revision is now accepted and ready to land. Looks visually appealing to me, with one question: How does this look on low-end hardware where there's compositing but no blur? REPOSITORY R242 Plasma Framework

D28200: Enable wrapping of error messages which use KMessageWidget

develoot added a comment. In D28200#633124 , @ngraham wrote: > Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information? My email address is devel...@gmail.com. thanks.

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. In D28200#636071 , @develoot wrote: > In D28200#633124 , @ngraham wrote: > > > Anyway, @develoot, could you provide your email address so we can land this patch with proper

D28326: [UnindexedFileIndexer] Only mark file for content indexing when needed

This revision was automatically updated to reflect the committed changes. Closed by commit R293:0912abcaa1c9: [UnindexedFileIndexer] Only mark file for content indexing when needed (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D28325: [Inotify] Call QFile::decode only in a single place

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b071a8b53fdb: [Inotify] Call QFile::decode only in a single place (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28325?vs=78606=78672#toc REPOSITORY R293 Baloo CHANGES

D28200: Enable wrapping of error messages which use KMessageWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d9bf6f53a036: Enable wrapping of error messages which use KMessageWidget (authored by develoot, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28352: [BasicIndexingJob] Remove unused include

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5c8e44d6f0f8: [BasicIndexingJob] Remove unused include (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28352?vs=78661=78674 REVISION DETAIL

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28327: [Inotify] Start the MoveFrom expire timer at most once per inotify batch

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1e7145ac06c0: [Inotify] Start the MoveFrom expire timer at most once per inotify batch (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I'll make this patch again, as much has change since then, there are things I'd do differently, and I'm not a fan of rebasing svg files. I will post the progress I did there. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added inline comments. INLINE COMMENTS > metadata.desktop.cmake:99 > -contrast=0.2 > -#intensity is disabled, in order to auto adjust to the chosen theme color > -#intensity=2.0 I changed this because: simply put, it doesn't work. I opened a bug about it

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove abandoned this revision. niccolove added a comment. in favor of https://phabricator.kde.org/D28353 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: trmdi, cblack, ndavis, filipf, ngraham,

D28355: Introduce function ecm_install_configured_file

davidedmundson created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This, as the name suggests, configures a file and installs it. It's not

<    1   2